Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(demo): Improve bug report button in demo #5510

Merged
merged 1 commit into from
Aug 21, 2023

Conversation

theodab
Copy link
Contributor

@theodab theodab commented Aug 19, 2023

This updates the bug template for the bug report button in the demo, to be closer to the current bug template.
It also adds the bug label, and makes it fill out the URIs of the asset playing in a more readable way.

Fixes #5056

@theodab theodab added type: enhancement New feature or request component: demo page The issue is in the demo page; does not affect production applications labels Aug 19, 2023
This updates the bug template for the bug report button in the demo,
to be closer to the current bug template.
It also adds the bug label, and makes it fill out the URIs of the asset
playing in a more readable way.

Fixes shaka-project#5056


**What configuration are you using? What is the output of `player.getConfiguration()`?**
<!-- NOTE:
Copy link
Contributor Author

@theodab theodab Aug 19, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried to add code to automatically fill this out, like some of the other parameters here.
However, the github API has a length limit, and that made the request too long.

@github-actions
Copy link
Contributor

Incremental code coverage: No instrumented code was changed.

@avelad avelad requested a review from joeyparrish August 19, 2023 16:41
@avelad avelad added this to the v4.4 milestone Aug 19, 2023
@theodab theodab merged commit 4329d79 into shaka-project:main Aug 21, 2023
@theodab theodab deleted the demoBugBranch branch August 21, 2023 11:54
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Oct 20, 2023
@shaka-project shaka-project locked as resolved and limited conversation to collaborators Oct 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
component: demo page The issue is in the demo page; does not affect production applications status: archived Archived and locked; will not be updated type: enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Demo app: 'REPORT BUG' button does not use bug report template and does not add 'type: bug' label
3 participants